justmarvinn/luckfox-pico-sdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix set spi mode and bits length

Browse Source 
Incorrect order of calling ioctl read and write functions in setting spi mode and bit length. Function parameters are overwritten with the value read from ioctl. First you need to write the value, and then read.
This commit is contained in:
Sergei Rebrov 2024-09-11 23:43:16 +03:00 committed by GitHub
parent e79fd21975
commit 24e28af57c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
media/luckfox/src/luckfox_spi.c
View File

@ -46,13 +46,13 @@ int luckfox_spi_init(char *dev, uint32_t mode, uint8_t bits, uint32_t speed)
} }
// Set SPI mode // Set SPI mode
ret = ioctl(fd, SPI_IOC_RD_MODE, &mode); ret = ioctl(fd, SPI_IOC_WR_MODE, &mode);
if (ret == -1) if (ret == -1)
{ {
printf("SPI_IOC_RD_MODE error......\n "); printf("SPI_IOC_RD_MODE error......\n ");
goto fd_close; goto fd_close;
} }
ret = ioctl(fd, SPI_IOC_WR_MODE, &mode); ret = ioctl(fd, SPI_IOC_RD_MODE, &mode);
if (ret == -1) if (ret == -1)
{ {
printf("SPI_IOC_WR_MODE error......\n "); printf("SPI_IOC_WR_MODE error......\n ");
@ -60,13 +60,13 @@ int luckfox_spi_init(char *dev, uint32_t mode, uint8_t bits, uint32_t speed)
} }
// Set the length of SPI communication // Set the length of SPI communication
ret = ioctl(fd, SPI_IOC_RD_BITS_PER_WORD, &bits); ret = ioctl(fd, SPI_IOC_WR_BITS_PER_WORD, &bits);
if (ret == -1) if (ret == -1)
{ {
printf("SPI_IOC_RD_BITS_PER_WORD error......\n "); printf("SPI_IOC_RD_BITS_PER_WORD error......\n ");
goto fd_close; goto fd_close;
} }
ret = ioctl(fd, SPI_IOC_WR_BITS_PER_WORD, &bits); ret = ioctl(fd, SPI_IOC_RD_BITS_PER_WORD, &bits);
if (ret == -1) if (ret == -1)
{ {
printf("SPI_IOC_WR_BITS_PER_WORD error......\n "); printf("SPI_IOC_WR_BITS_PER_WORD error......\n ");